Add sorting entity feature #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
@danielpetisme it seems that the following file https://github.com/jhipster/generator-jhipster-quarkus/blob/main/generators/entity-server/templates/quarkus/src/main/java/package/_partials/imperative/common/get_all.ejs is not used and is a duplicate from this one in the web folder. Should we remove this file? I struggle a bit to understand where I should do the modification. The get_all from common folder is not used in the project. Maybe it's a mistake? |
|
Unless this question about common/get_all.ejs file, I think this PR is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #95
It should works but I open it as draft because I need to test with more scenarios.
@inngvar